thonny: Update to version 5.0.0, fix portable asset rename#18321
Open
l46983284-cpu wants to merge 1 commit into
Open
thonny: Update to version 5.0.0, fix portable asset rename#18321l46983284-cpu wants to merge 1 commit into
l46983284-cpu wants to merge 1 commit into
Conversation
Upstream renamed the Windows portable zip from thonny-$version-windows-portable.zip to thonny-$version-windows-portable-x64.zip in 5.0.0. Update current URL/hash and autoupdate/checkver so the scheduled updater keeps working. Signed-off-by: Alex Chen <l46983284@gmail.com>
Contributor
Author
|
/verify |
📝 WalkthroughWalkthroughThe Thonny bucket manifest is updated from version 4.1.7 to 5.0.0. The Windows portable download URL and hash are replaced, while the autoupdater regex now supports an optional Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All changes look good. Wait for review from human collaborators. thonny
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/thonny.json (1)
2-24: 📐 Maintainability & Code Quality | 🔵 TrivialRun the standard Scoop validation before merging.
scoop config debug true scoop config gh_token <your-github-token> .\bin\checkver.ps1 -App thonny -f .\bin\formatjson.ps1 -App thonny scoop install bucket/thonny.json -a 64bitAs per path instructions, validate version detection, formatting, and installation locally.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/thonny.json` around lines 2 - 24, Run the standard Scoop validation for the thonny manifest: enable debug mode and configure a GitHub token, then execute checkver.ps1 with force, formatjson.ps1, and a 64-bit installation of bucket/thonny.json. Resolve any version-detection, formatting, or installation issues before merging.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/thonny.json`:
- Around line 2-24: Run the standard Scoop validation for the thonny manifest:
enable debug mode and configure a GitHub token, then execute checkver.ps1 with
force, formatjson.ps1, and a 64-bit installation of bucket/thonny.json. Resolve
any version-detection, formatting, or installation issues before merging.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: de9a2bc0-2269-4b20-9683-adeab0969b59
📒 Files selected for processing (1)
bucket/thonny.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18318
Upstream 5.0.0 renamed the Windows portable zip to
thonny-$version-windows-portable-x64.zip, so the old autoupdate pattern 404s. This PR bumps to 5.0.0, updates the hash from a full download of the new asset, and fixes checkver/autoupdate for the new name.<manifest-name[@version]|chore>: <general summary of the pull request>